Skip to content

Conversation

@taiki-e
Copy link
Member

@taiki-e taiki-e commented Apr 10, 2020

Replaces #488

@jeehoonkang
Copy link
Contributor

I'm happy with the change. Thank you for your detailed analysis: #488 (comment)

bors r+

@bors bors bot merged commit 0599b8e into master Apr 10, 2020
@taiki-e taiki-e deleted the github-actions branch April 10, 2020 09:44
@jeehoonkang
Copy link
Contributor

Dear @taiki-e,

It seems old PRs not are tested with the new CI, e.g., #485 . Do you happen to know how to test them in the new CI?

@taiki-e
Copy link
Member Author

taiki-e commented Apr 11, 2020

@jeehoonkang
Unfortunately, I think it needs to rebase (or merge master branch to PR's branch).

(However, as bors run the test when merging, if PR is likely to pass the test, we may be able to use bors.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants